Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub.dev packages review #342

Closed
11 tasks done
sarika01 opened this issue Jan 24, 2022 · 19 comments
Closed
11 tasks done

Pub.dev packages review #342

sarika01 opened this issue Jan 24, 2022 · 19 comments
Assignees
Labels
3 SP 3 Story Points - 1 Day Small Content Creation, writing, editing, review PR29 Jan | Feb 2022 Sprint Planning PR30 Feb 2022 Sprint Planning PR31 Feb | Mar 2022 Sprint Planning PR32 Mar 2022 Sprint Planning PR33 Mar | Apr 2022 Sprint Planning

Comments

@sarika01
Copy link
Contributor

sarika01 commented Jan 24, 2022

Lead: @ksanty

Standard operating procedures for documentation here

The packages are published with updated documentation and example app. Links working

Please review the published version on pub.dev and provide feedback.

Also, any SEO keywords suggestion would be useful. See comments below. SEO and samples and examples pending.

@ksanty
Copy link
Member

ksanty commented Jan 25, 2022

at_common_flutter review:

  • Read and verify content for comprehension
  • Technical review of samples and examples @nickelskevin
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found Issue:

@nickelskevin I'm unsure about where links should point to, they all work and things look great to me here. Also unsure about SEO strategy and how we handle.

@ksanty
Copy link
Member

ksanty commented Jan 28, 2022

at_onboarding_flutter review:

  • Read and verify content for comprehension
  • Technical review of samples and examples @nickelskevin
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found issues:

@nickelskevin I'm unsure about where links should point to, they all work and things look great to me here. Also unsure about SEO strategy and how we handle.

@ksanty ksanty closed this as completed Jan 28, 2022
@ksanty ksanty reopened this Jan 28, 2022
@ksanty
Copy link
Member

ksanty commented Jan 28, 2022

at_backupkey_flutter review:

  • Read and verify content for comprehension
  • Technical review of samples and examples @nickelskevin
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found issues:

@nickelskevin I'm unsure about where links should point to, they all work and things look great to me here. Also unsure about SEO strategy and how we handle.

@ksanty
Copy link
Member

ksanty commented Jan 28, 2022

at_contacts_flutter review:

  • Read and verify content for comprehension
  • Technical review of samples and examples @nickelskevin
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found Issues:

@nickelskevin I'm unsure about where links should point to, they all work and things look great to me here. Also unsure about SEO strategy and how we handle.

@XavierChanth
Copy link
Member

@sarika01 The example for at_backupkey_flutter is not using null safety (trunk branch).

@ksanty ksanty added the PR30 Feb 2022 Sprint Planning label Feb 7, 2022
@sarika01 sarika01 added the PR31 Feb | Mar 2022 Sprint Planning label Feb 21, 2022
@sarika01
Copy link
Contributor Author

sarika01 commented Feb 22, 2022

@ksanty Adding some more packages which were updated for documentation. (reposted list in root above)

@XavierChanth XavierChanth self-assigned this Feb 22, 2022
@ksanty ksanty added the blocker Flagging for resolution label Feb 23, 2022
@ksanty ksanty removed the blocker Flagging for resolution label Mar 7, 2022
@ksanty
Copy link
Member

ksanty commented Mar 7, 2022

at_chat_flutter review:

  • Read and verify content for comprehension
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

@ksanty
Copy link
Member

ksanty commented Mar 7, 2022

at_events_flutter review:

  • Read and verify content for comprehension
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found issue:

@ksanty
Copy link
Member

ksanty commented Mar 7, 2022

at_invitation_flutter review:

  • Read and verify content for comprehension
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

@ksanty
Copy link
Member

ksanty commented Mar 7, 2022

at_location_flutter review:

  • Read and verify content for comprehension
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found issue:

@ksanty
Copy link
Member

ksanty commented Mar 7, 2022

at_notify_flutter review:

  • Read and verify content for comprehension
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found issue:

@ksanty
Copy link
Member

ksanty commented Mar 7, 2022

at_sync_ui_flutter review:

  • Read and verify content for comprehension
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

Found issue:

@ksanty
Copy link
Member

ksanty commented Mar 7, 2022

at_theme_flutter review:

  • Read and verify content for comprehension
  • SEO included (need to open a new ticket once we've identified keywords)
  • Spelling, grammar
  • Verify links / badges work properly

@sarika01 sarika01 added the PR32 Mar 2022 Sprint Planning label Mar 7, 2022
@sarika01
Copy link
Contributor Author

Some more package document correction is yet to be published. Hence, moving to next sprint.

@sarika01 sarika01 added the PR33 Mar | Apr 2022 Sprint Planning label Mar 21, 2022
@sarika01
Copy link
Contributor Author

sarika01 commented Apr 4, 2022

The pending packages have been published. @ksanty Please validate.

@yahu1031
Copy link
Member

@sarika01 I see no info about getting an API for the app in the at_onboarding_widget package docs. Can you please have a look at that? (Hoping no need to raise another ticket for this)

@sarika01
Copy link
Contributor Author

@yahu1031 Can you please elaborate on the requirement or the use-case that you are looking at?

@yahu1031
Copy link
Member

There is no information on how to get the API key for the app in the at_onboarding_flutter package documentation. But in the code snippet, We mentioned that API Key is mandatory for production environment.. So need at least a line about how to get the API key(mail to get-key@atsign.com). We used to have it, but on the docs update, there are no traces of it.

@XavierChanth
Copy link
Member

Closing as stale, we've done countless releases since this card has been worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 SP 3 Story Points - 1 Day Small Content Creation, writing, editing, review PR29 Jan | Feb 2022 Sprint Planning PR30 Feb 2022 Sprint Planning PR31 Feb | Mar 2022 Sprint Planning PR32 Mar 2022 Sprint Planning PR33 Mar | Apr 2022 Sprint Planning
Projects
None yet
Development

No branches or pull requests

6 participants