null-aware operator was used on non-null value in at_contacts_flutter and at_onboarding_flutter

[yahu1031]

Describe the bug
In at_contacts_flutter and at_onboarding_flutter has null-aware issue with WidgetsBinding.instance.

To Reproduce
Steps to reproduce the behavior:

1. Install/Upgrade Flutter to 3.0.0
2. Upgrade all you at packages
3. Run any app.

Expected behavior
This Error/Warning is not expected

Logs

Launching lib/main.dart on iPhone 13 in debug mode...
Xcode build done.                                           37.4s
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../Development/flutter/packages/flutter/lib/src/widgets/binding.dart').

            WidgetsBinding.instance!.addPostFrameCallback((Duration timeStamp) {
                           ^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../Development/flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance!.addPostFrameCallback((_) {
                   ^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../Development/flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance!.addPostFrameCallback((Duration timeStamp) {
                   ^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../Development/flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance!.addPostFrameCallback((timeStamp) async {
                   ^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../Development/flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance!.addPostFrameCallback((timeStamp) async {
                   ^
: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../../Development/flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance?.addPostFrameCallback((timeStamp) async {
                   ^

Connecting to VM Service at ws://127.0.0.1:52300/lITl4cNAfHU=/ws
flutter: FINER|2022-05-12 22:34:53.334998|at_skeleton_app|Environment failed to load from .env:
flutter: SEVERE|2022-05-12 22:34:54.114698|AtClientService|Atsign not found
flutter: INFO|2022-05-12 22:34:54.205284|QR Scan|camera status => PermissionStatus.denied
flutter: INFO|2022-05-12 22:34:54.206357|QR Scan|storage status is PermissionStatus.granted

Smartphone (please complete the following information):

• Device: iPhone12
• OS: iOS15.4

Were you using an @‎application when the bug was found?

• @dude

[yahu1031]

@sachins-geekyants I don't think this takes 8SP. This is because of the Flutter 3.0 version. WidgetBinding.instance is not nullable anymore. Previously it used to be nullable. Not sure, Please LMK this is not what this issue is about.

[sachins-geekyants]

Along with above mentioned WidgetsBinding.instance null aware issue we also have to apply lint rules in packages.

• at_backupkey_flutter
• at_chat_flutter
• at_common_flutter
• at_contacts_flutter
• at_contacts_group_flutter
• at_events_flutter
• at_location_flutter
• at_notify_flutter
• at_onboarding_flutter
• at_sync_ui_flutter
• at_theme_flutter

[sachins-geekyants]

null aware fix and linting have been applied to packages - need to test examples and deploy.
Moving to next sprint.

[nitesh2599]

Packages testing and publishing:

• at_backupkey_flutter
• at_chat_flutter
• at_common_flutter
• at_contacts_flutter
• at_contacts_group_flutter
• at_events_flutter
• at_location_flutter
• at_notify_flutter
• at_onboarding_flutter
• at_sync_ui_flutter
• at_theme_flutter

[nitesh2599]

@yahu1031 We have removed the bang operator and published the packages.

[yahu1031]

Recently go this from one of the interns. Could you please check this? @nitesh2599

[nitesh2599]

@yahu1031 Can you ask for his flutter version ?

[yahu1031]

2.10.3

[nitesh2599]

This is a change made with respect to flutter 3.0 .

If he wants to use any flutter 2... versions, he should use previous versions of the package.

[sachins-geekyants]

@yahu1031 Is the issue resolved? can we close this ticket?

[yahu1031]

yes, I'm closing this as it was resolved.