Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] SSHNP - Docker Feedback #270

Closed
5 tasks done
Tracked by #135
XavierChanth opened this issue Jul 21, 2023 · 3 comments
Closed
5 tasks done
Tracked by #135

[Tracker] SSHNP - Docker Feedback #270

XavierChanth opened this issue Jul 21, 2023 · 3 comments
Assignees

Comments

@XavierChanth
Copy link
Member

XavierChanth commented Jul 21, 2023

Tasks

@XavierChanth XavierChanth self-assigned this Jul 21, 2023
@XavierChanth XavierChanth changed the title [Tracker] Docker Stuff [Tracker] SSHNP - Docker Feedback Jul 21, 2023
@XavierChanth
Copy link
Member Author

Odds and ends that I need cleanup / do in docker for customers, not super urgent as we've addressed all of the immediate problems.

@gkc
Copy link
Contributor

gkc commented Aug 7, 2023

Setting to P2

@XavierChanth
Copy link
Member Author

Checking: 'Allow rebuilds with dockerhub build script by removing the "+" from the tag'

As we should never have to create a tag with a +build_number, we should only ever rebuild by doing a run of the dockerhub sshnpd script on the same tag. If we are on a different commit, then it should at least be a patch increase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants