Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do direct ssh when using an rv #218

Closed
8 of 9 tasks
Tracked by #135
XavierChanth opened this issue Jun 25, 2023 · 2 comments
Closed
8 of 9 tasks
Tracked by #135

feat: Do direct ssh when using an rv #218

XavierChanth opened this issue Jun 25, 2023 · 2 comments
Assignees

Comments

@XavierChanth
Copy link
Member

XavierChanth commented Jun 25, 2023

Sshnp no double ssh option - as we have the rv we do not have to double ssh. Option shpuld still be there and only used if needed. I.E. a direct connectoon (-h with no @)

Tasks

@XavierChanth XavierChanth reopened this Jul 10, 2023
@gkc gkc changed the title Add back non-atsign host support feat: Do direct ssh when using an rv Aug 7, 2023
@gkc gkc assigned gkc and unassigned cconstab and XavierChanth Aug 7, 2023
@gkc
Copy link
Contributor

gkc commented Aug 7, 2023

Spiked at the weekend and got this working albeit resulted in a bunch of bug-prone hard-to-grok difficult-to-maintain code. See plan in issue description above

@gkc
Copy link
Contributor

gkc commented Aug 21, 2023

This is complete except for the last task (Augment end-to-end tests to cover both direct ssh and double ssh) which is also covered in the release 4.0.0 tracker, so will close this ticket as completed.

@gkc gkc closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants