fix: sshnp exit if atSign DNE, sshnpd wait for atSign to exist #211

JeremyTubongbanua · 2023-06-17T03:14:59Z

What I did

util function atSignIsActivated
sshnpd sleeps 5 seconds, if sshnp atSign does not exist
sshnp exit(1), if sshnpd atSign does not exist

Fixes issue #118

closes #188

JeremyTubongbanua · 2023-06-17T04:07:26Z

@cconstab
For sshnpd, if the sshnp atSign does not exist, do we want to exit(1), or do a while() {sleep 5} or something?

gkc · 2023-06-19T22:12:47Z

lib/atsign_exists.dart

+/// Checks if the provided atSign's atServer has been properly activated with a public RSA key.
+/// `atClient` must be authenticated
+/// `atSign` is the atSign to check
+Future<bool> atSignIsActivated(final AtClient atClient, String atSign) async {


Can you add into the sshnp_utils.dart please? Keeps things tidy

gkc · 2023-06-19T22:14:05Z

lib/atsign_exists.dart

+  try {
+    await atClient.get(publicKey);
+    return true;
+  } catch (e) {


Shouldn't you distinguish between errors? For example if the atServer is not reachable for some reason, that is different than getting a KeyNotFound exception

51781b9

Ah, is this what you mean?

The AtClient.get exceptions are:

Throws [AtKeyException] for the invalid key formed Throws [AtDecryptionException] if fails to decrypt the value Throws [AtPrivateKeyNotFoundException] if the encryption private key is not found to decrypt the value Throws [AtPublicKeyChangeException] if the encryption public key used encrypt the value is different from the current encryption public key(at the time of decryption) Throws [SharedKeyNotFoundException] if the shared key to decrypt the value is not found Throws [SelfKeyNotFoundException] if the self encryption key is not found. Throws [AtClientException] if the cloud secondary is invalid or not reachable

The only 2 possible exceptions should be AtKeyException and AtClientException, right?

gkc · 2023-06-19T22:14:40Z

lib/sshnp.dart

@@ -177,6 +178,10 @@ class SSHNP {
      throw StateError('Cannot init() - already initialized');
    }

+    if(!(await atSignIsActivated(atClient, sshnpdAtSign))) {
+        throw ('sshnpd atSign $sshnpdAtSign does not exist');


With your current implementation, it might exist, but not yet be onboarded

The exception message was incorrect
e2fd442

Oh, an atSign can have a publickey but not be onboarded?

EDIT

I find that it does not exist, as long as we bypass cache

@jeremy_0 plookup:bypassCache:true:publickey@slow674 => error:{"errorCode":"AT0011","errorDescription":"Internal server exception : Request to remote secondary @slow674 at null:null received error response 'AT0015-Exception: public:publickey@slow674 does not exist in keystore'"} @jeremy_0 plookup:publickey@slow674 => data:MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAl6HAhNfIC+gTPzVNk6ptm8rWLe2I2nDhktEFGlFUuNaHF7T4lS+n9zVLApKbwL/tXEMJAFZ2B7YhLJh4BILsAxsjMqTUuiMNVzpuWKEr3o06Nr7VBzu1n0PVcHdB1akj/pHhk60D7HWzqN2FZBYS0h1rYeVjpDVCh/WxPtqg/0f7sEv4uWpsWFivQVh7UPp5zB8fAj2ypmSyEvuMDU63N8pUUSmAWr7qKbuE+4Jj8QPY7C6CBBHjukMd5+oqkKGSqEkSn8enc22KLaFJiXkKKbqxVhLHBMCLsUl+1krxeFNU2PmTAcc6Ek+yby7XM0erhy99vbkaAC/cCuSeSS2qjQIDAQAB

gkc · 2023-06-25T18:30:25Z

@cconstab For sshnpd, if the sshnp atSign does not exist, do we want to exit(1), or do a while() {sleep 5} or something?

@JeremyTubongbanua - @cconstab and I discussed this last week ... we think a while (can't fetch public key) {try; sleep} is best

JeremyTubongbanua · 2023-06-27T01:28:19Z

@gkc Done in f6fb133

…xception

JeremyTubongbanua · 2023-06-27T04:44:57Z

Here's the results of my testing as of the most recent commit:

Testing that sshnp does not continue, if the other atSign is alive, but hasn't been onboarded yet:

atsign@6d0c777a3b17:~/.local/bin$ ./sshnp -f @jeremy_0 -t @noblesnowbaboon -s id_ed25519.pub -d docker -h @rv_am
Unhandled exception:
sshnpd atSign @noblesnowbaboon is not activated.
#0      SSHNP.init (package:sshnoports/sshnp.dart:181)
<asynchronous suspension>
#1      main (file:///build/repo/bin/sshnp.dart:21)
<asynchronous suspension>

Testing that sshnpd keeps on trying until the other atSign's public:publickey exists

atsign@8ea01a4b8c7a:~/.local/bin$ ./sshnpd -a @smoothalligator -m @noblesnowbaboon -d docker -s -u -v
...
WARNING|2023-06-27 04:40:25.940721| sshnpd |Waiting for @noblesnowbaboon to be activated... 

WARNING|2023-06-27 04:40:31.130089| sshnpd |Waiting for @noblesnowbaboon to be activated... 

WARNING|2023-06-27 04:40:36.445747| sshnpd |Waiting for @noblesnowbaboon to be activated...

Here are the sshnpd logs once I activate the sshnp atSign (in this case, @noblesnowbaboon) using at_activate

WARNING|2023-06-27 04:42:52.471506| sshnpd |Waiting for @noblesnowbaboon to be activated... 

INFO|2023-06-27 04:42:52.899482|AbstractAtKeyEncryption (@smoothalligator)|Encrypted shared symmetric key for @smoothalligator not found in local storage 

INFO|2023-06-27 04:42:52.899658|AbstractAtKeyEncryption (@smoothalligator)|Deleting @noblesnowbaboon:shared_key@smoothalligator from LocalSecondary 

INFO|2023-06-27 04:42:52.900637|AbstractAtKeyEncryption (@smoothalligator)|Fetching shared symmetric key for @smoothalligator from atServer 

INFO|2023-06-27 04:42:52.961281|AbstractAtKeyEncryption (@smoothalligator)|Creating new shared symmetric key as @smoothalligator for @noblesnowbaboon 

INFO|2023-06-27 04:42:52.963822|AbstractAtKeyEncryption (@smoothalligator)|Deleting @noblesnowbaboon:shared_key@smoothalligator from RemoteSecondary 

INFO|2023-06-27 04:42:53.072124|AbstractAtKeyEncryption (@smoothalligator)|Storing new shared symmetric key to atServer 

INFO|2023-06-27 04:42:53.144331|AbstractAtKeyEncryption (@smoothalligator)|Storing new shared symmetric key to local storage 

INFO|2023-06-27 04:42:53.145216|AbstractAtKeyEncryption (@smoothalligator)|'Their' copy of shared symmetric key for @noblesnowbaboon not found in local storage - will check atServer 

INFO|2023-06-27 04:42:53.271397|AbstractAtKeyEncryption (@smoothalligator)|Saving 'their' copy of shared symmetric key for @noblesnowbaboon to atServer 

INFO|2023-06-27 04:42:53.339776|AbstractAtKeyEncryption (@smoothalligator)|Saving 'their' copy of shared symmetric key for @noblesnowbaboon to local storage 

INFO|2023-06-27 04:42:54.041067| sshnpd |SUCCESS:id: 270e510e-412e-4666-83f8-39866465410c status: NotificationStatusEnum.delivered atsign 

INFO|2023-06-27 04:42:55.103470|SyncService (@smoothalligator)|72717253|Returning serverCommitId 32573 

INFO|2023-06-27 04:42:55.168053|SyncService (@smoothalligator)|72717253|Returning serverCommitId 32573 

SEVERE|2023-06-27 04:42:55.281406|EncryptionUtil|Error while decrypting value: Invalid argument(s): Invalid or corrupted pad block 

WARNING|2023-06-27 04:42:55.281474|SyncService (@smoothalligator)|Exception occurred when setting conflict info for @noblesnowbaboon:shared_key@smoothalligator | Exception: Invalid argument(s): Invalid or corrupted pad block 

INFO|2023-06-27 04:42:55.367503|SyncService (@smoothalligator)|72717253|Inside syncComplete. syncRequest.requestSource : SyncRequestSource.system; syncRequest.onDone : Closure: (SyncResult) => void from Function '_onDone@118025363':. 

INFO|2023-06-27 04:42:55.427854|SyncService (@smoothalligator)|72717253|Returning serverCommitId 32576

Then in the sshnp container, we test sshing into the sshnpd container (one final test that it all still works):

./sshnp -f @noblesnowbaboon -t @smoothalligator -s id_ed25519.pub -d docker -h @rv_am
ssh -p 40873 atsign@localhost -i /atsign/.ssh/id_ed25519
...
atsign@8ea01a4b8c7a:~$ ps -a
  PID TTY          TIME CMD
   24 pts/0    00:00:00 bash
   26 pts/0    00:00:06 dart:sshnpd
   73 pts/1    00:00:00 ps
...

JeremyTubongbanua · 2023-06-28T01:52:06Z

Here's the results of my testing as of the most recent commit:

Testing that sshnp does not continue, if the other atSign is alive, but hasn't been onboarded yet:

atsign@6d0c777a3b17:~/.local/bin$ ./sshnp -f @jeremy_0 -t @noblesnowbaboon -s id_ed25519.pub -d docker -h @rv_am
Unhandled exception:
sshnpd atSign @noblesnowbaboon is not activated.
#0      SSHNP.init (package:sshnoports/sshnp.dart:181)
<asynchronous suspension>
#1      main (file:///build/repo/bin/sshnp.dart:21)
<asynchronous suspension>

Testing that sshnpd keeps on trying until the other atSign's public:publickey exists

atsign@8ea01a4b8c7a:~/.local/bin$ ./sshnpd -a @smoothalligator -m @noblesnowbaboon -d docker -s -u -v
...
WARNING|2023-06-27 04:40:25.940721| sshnpd |Waiting for @noblesnowbaboon to be activated... 

WARNING|2023-06-27 04:40:31.130089| sshnpd |Waiting for @noblesnowbaboon to be activated... 

WARNING|2023-06-27 04:40:36.445747| sshnpd |Waiting for @noblesnowbaboon to be activated...

Here are the sshnpd logs once I activate the sshnp atSign (in this case, @noblesnowbaboon) using at_activate

WARNING|2023-06-27 04:42:52.471506| sshnpd |Waiting for @noblesnowbaboon to be activated... 

INFO|2023-06-27 04:42:52.899482|AbstractAtKeyEncryption (@smoothalligator)|Encrypted shared symmetric key for @smoothalligator not found in local storage 

INFO|2023-06-27 04:42:52.899658|AbstractAtKeyEncryption (@smoothalligator)|Deleting @noblesnowbaboon:shared_key@smoothalligator from LocalSecondary 

INFO|2023-06-27 04:42:52.900637|AbstractAtKeyEncryption (@smoothalligator)|Fetching shared symmetric key for @smoothalligator from atServer 

INFO|2023-06-27 04:42:52.961281|AbstractAtKeyEncryption (@smoothalligator)|Creating new shared symmetric key as @smoothalligator for @noblesnowbaboon 

INFO|2023-06-27 04:42:52.963822|AbstractAtKeyEncryption (@smoothalligator)|Deleting @noblesnowbaboon:shared_key@smoothalligator from RemoteSecondary 

INFO|2023-06-27 04:42:53.072124|AbstractAtKeyEncryption (@smoothalligator)|Storing new shared symmetric key to atServer 

INFO|2023-06-27 04:42:53.144331|AbstractAtKeyEncryption (@smoothalligator)|Storing new shared symmetric key to local storage 

INFO|2023-06-27 04:42:53.145216|AbstractAtKeyEncryption (@smoothalligator)|'Their' copy of shared symmetric key for @noblesnowbaboon not found in local storage - will check atServer 

INFO|2023-06-27 04:42:53.271397|AbstractAtKeyEncryption (@smoothalligator)|Saving 'their' copy of shared symmetric key for @noblesnowbaboon to atServer 

INFO|2023-06-27 04:42:53.339776|AbstractAtKeyEncryption (@smoothalligator)|Saving 'their' copy of shared symmetric key for @noblesnowbaboon to local storage 

INFO|2023-06-27 04:42:54.041067| sshnpd |SUCCESS:id: 270e510e-412e-4666-83f8-39866465410c status: NotificationStatusEnum.delivered atsign 

INFO|2023-06-27 04:42:55.103470|SyncService (@smoothalligator)|72717253|Returning serverCommitId 32573 

INFO|2023-06-27 04:42:55.168053|SyncService (@smoothalligator)|72717253|Returning serverCommitId 32573 

SEVERE|2023-06-27 04:42:55.281406|EncryptionUtil|Error while decrypting value: Invalid argument(s): Invalid or corrupted pad block 

WARNING|2023-06-27 04:42:55.281474|SyncService (@smoothalligator)|Exception occurred when setting conflict info for @noblesnowbaboon:shared_key@smoothalligator | Exception: Invalid argument(s): Invalid or corrupted pad block 

INFO|2023-06-27 04:42:55.367503|SyncService (@smoothalligator)|72717253|Inside syncComplete. syncRequest.requestSource : SyncRequestSource.system; syncRequest.onDone : Closure: (SyncResult) => void from Function '_onDone@118025363':. 

INFO|2023-06-27 04:42:55.427854|SyncService (@smoothalligator)|72717253|Returning serverCommitId 32576

Then in the sshnp container, we test sshing into the sshnpd container (one final test that it all still works):

./sshnp -f @noblesnowbaboon -t @smoothalligator -s id_ed25519.pub -d docker -h @rv_am
ssh -p 40873 atsign@localhost -i /atsign/.ssh/id_ed25519
...
atsign@8ea01a4b8c7a:~$ ps -a
  PID TTY          TIME CMD
   24 pts/0    00:00:00 bash
   26 pts/0    00:00:06 dart:sshnpd
   73 pts/1    00:00:00 ps
...

cc @gkc

gkc

Nice work @JeremyTubongbanua

JeremyTubongbanua self-assigned this Jun 17, 2023

JeremyTubongbanua requested review from cconstab and gkc June 17, 2023 04:06

gkc requested changes Jun 19, 2023

View reviewed changes

JeremyTubongbanua marked this pull request as ready for review June 20, 2023 06:59

JeremyTubongbanua requested a review from gkc June 20, 2023 06:59

JeremyTubongbanua changed the title ~~feat: exit(1), if other atSign dne~~ feat: exit(1), if other atSign is not activated Jun 20, 2023

JeremyTubongbanua mentioned this pull request Jun 26, 2023

at_activate can deliver an atKey file but not actually confirm the keys are in place on the atServer atsign-foundation/at_libraries#363

Closed

JeremyTubongbanua added 6 commits June 27, 2023 00:07

feat: exit(1), if other atSign dne

9470593

feat: util function

16ddca2

refactor: atsign_exists.dart spacings

9cb7738

refactor: exception message

50570aa

refactor: move function to sshnp_utils and throws error for AtClientE…

5d84358

…xception

feat: sleep 5 seconds if sshnp atSign is not activated inside of sshnpd

26fccd8

JeremyTubongbanua force-pushed the jeremy-devicename-fix1 branch from f6fb133 to 26fccd8 Compare June 27, 2023 04:08

JeremyTubongbanua added 4 commits June 27, 2023 00:20

chore: check for internal server error

115ebbf

chore: debugging

22c5eca

fix: check for public:publickey in error message

370a416

fix: more string check on the if condition

7041334

JeremyTubongbanua changed the title ~~feat: exit(1), if other atSign is not activated~~ feat: check if atSign is activated first and act accordingly Jun 27, 2023

docs: atSignIsActivated function

407d4c6

XavierChanth approved these changes Jun 28, 2023

View reviewed changes

JeremyTubongbanua changed the title ~~feat: check if atSign is activated first and act accordingly~~ fix: sshnp exit if atSign DNE, sshnpd wait for atSign to exist Jun 28, 2023

JeremyTubongbanua requested a review from XavierChanth June 28, 2023 02:26

XavierChanth approved these changes Jun 28, 2023

View reviewed changes

gkc approved these changes Jun 28, 2023

View reviewed changes

gkc merged commit 948fb5d into trunk Jun 28, 2023
1 check passed

XavierChanth mentioned this pull request Jul 12, 2023

TRUNK SSHNP vs. RELEASE v3.2.0 SSHNPD does not work with a new device name #251

Closed

JeremyTubongbanua mentioned this pull request Aug 23, 2023

Cron job eventually stops attempting to start daemon #379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: sshnp exit if atSign DNE, sshnpd wait for atSign to exist #211

fix: sshnp exit if atSign DNE, sshnpd wait for atSign to exist #211

JeremyTubongbanua commented Jun 17, 2023 •

edited

JeremyTubongbanua commented Jun 17, 2023

gkc Jun 19, 2023

JeremyTubongbanua Jun 20, 2023

gkc Jun 19, 2023

JeremyTubongbanua Jun 20, 2023

gkc Jun 19, 2023

JeremyTubongbanua Jun 20, 2023

JeremyTubongbanua Jun 20, 2023 •

edited

gkc commented Jun 25, 2023

JeremyTubongbanua commented Jun 27, 2023

JeremyTubongbanua commented Jun 27, 2023

JeremyTubongbanua commented Jun 28, 2023

gkc left a comment

fix: sshnp exit if atSign DNE, sshnpd wait for atSign to exist #211

fix: sshnp exit if atSign DNE, sshnpd wait for atSign to exist #211

Conversation

JeremyTubongbanua commented Jun 17, 2023 • edited

What I did

JeremyTubongbanua commented Jun 17, 2023

gkc Jun 19, 2023

Choose a reason for hiding this comment

JeremyTubongbanua Jun 20, 2023

Choose a reason for hiding this comment

gkc Jun 19, 2023

Choose a reason for hiding this comment

JeremyTubongbanua Jun 20, 2023

Choose a reason for hiding this comment

gkc Jun 19, 2023

Choose a reason for hiding this comment

JeremyTubongbanua Jun 20, 2023

Choose a reason for hiding this comment

JeremyTubongbanua Jun 20, 2023 • edited

Choose a reason for hiding this comment

gkc commented Jun 25, 2023

JeremyTubongbanua commented Jun 27, 2023

JeremyTubongbanua commented Jun 27, 2023

JeremyTubongbanua commented Jun 28, 2023

gkc left a comment

Choose a reason for hiding this comment

JeremyTubongbanua commented Jun 17, 2023 •

edited

JeremyTubongbanua Jun 20, 2023 •

edited