Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed typo which reintroduced a bug in SSHNP.getSshrvCommand #215

Merged
merged 1 commit into from Jun 22, 2023
Merged

fix: fixed typo which reintroduced a bug in SSHNP.getSshrvCommand #215

merged 1 commit into from Jun 22, 2023

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Jun 22, 2023

- What I did
fix: re-fixed this bug

- How I did it

  • Replace a usage of Platform.executable to use Platform.resolvedExecutable instead

- How to verify it

  • Run sshnp via PATH e.g. sshnp
  • Run sshnp with full path provided e.g. /Users/gary/dev/atsign/repos/sshnoports/bin/sshnp
  • Run sshnp with relative path provided e.g. while in the bin directory, ./sshnp

@gkc gkc mentioned this pull request Jun 22, 2023
Closed
@gkc gkc requested a review from cconstab June 22, 2023 14:24
@gkc gkc merged commit 8c74abc into trunk Jun 22, 2023
1 check passed
@gkc gkc deleted the gkx-fix-issue-148-again branch June 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconstab cconstab cconstab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sshnp has to run directly i.e. ./sshnp as it calls sshrv from the directory it is running in
2 participants
@gkc @cconstab