Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: more e2e test coverage - backwards compatibility #250

Merged
merged 6 commits into from Jul 12, 2023

Conversation

JeremyTubongbanua
Copy link
Member

@JeremyTubongbanua JeremyTubongbanua commented Jul 12, 2023

Related to #249

- What I did

  • added more e2e test coverage
  • local-release3.2.0
  • local-release3.3.0
  • local-release3.1.2
  • release3.2.0-local
  • release3.3.0-local
  • release3.1.2-local

- How I did it

- How to verify it

- Description for the changelog

closes #251

@JeremyTubongbanua JeremyTubongbanua self-assigned this Jul 12, 2023
@XavierChanth
Copy link
Member

XavierChanth commented Jul 12, 2023

@JeremyTubongbanua can you also add 3.1.2 against latest? (without removing 3.2.0)

@XavierChanth
Copy link
Member

Uh oh... the docker container was introduced in 3.2.0 ...

@JeremyTubongbanua
Copy link
Member Author

JeremyTubongbanua commented Jul 12, 2023

@XavierChanth 3.1.2 NPD and 3.2.0 NPD have the same issue trying to work with Latest NP

3.3.0 NPD works with Latest NP, though.

3.1.2NPD-local = https://github.com/atsign-foundation/sshnoports/actions/runs/5534168124/jobs/10098749981?pr=250

@XavierChanth
Copy link
Member

Thank you, I will investigate further... I think I know what it is

@JeremyTubongbanua JeremyTubongbanua marked this pull request as ready for review July 12, 2023 17:15
@JeremyTubongbanua JeremyTubongbanua merged commit 284b01c into trunk Jul 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRUNK SSHNP vs. RELEASE v3.2.0 SSHNPD does not work with a new device name
2 participants