fix: Correcting typo/bug in sshnp #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo prevents ssh command to run if cut and paste. This only hits if no ssh key is specified with -s
XavierChanth
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Came across bug when using sshnp with specifying the ssh key to be used (its in my .ssh/config). Found typo that is not caught in end to end tests @JeremyTubongbanua perhaps add one!
- How I did it
removed odd
-o sshtext- How to verify it
compiled and run manually
- Description for the changelog
Typo prevents ssh command to run if cut and paste. This only hits if no ssh key is specified with -s