feat: sshnp pure dart for direct ssh #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: fix a couple of bugs when using direct ssh which were introduced over the past month in the trunk branch - use 'localhost' for the host to ssh to in the SSHNP return value / output string - do not start sshrv when fetching host and port from sshrvd; do so only when using reverse ssh - refactor: move some shared constants into new file, common/defaults.dart - refactor: move some shared functions to common/utils.dart (generating ssh keys, adding to authorized_keys file and removing from authorized_keys file) - feat: add pure dart sshclient support to sshnp for direct ssh - feat: add `remoteSshdPort` and `idleTimeout` parameters to SSHNP - feat: add `localSshdPort` to SSHNPD - feat: add ephemeral keys support for direct ssh
…rt` (2) connect as `remoteUsername` fix: bug fix to `directSshViaExec` - fix the local port forwarding directive to use `remoteSshdPort` not `localSshdPort` feat: bin/sshnp : print the result to stderr if the result is SSHNPFailed feat: add `Future<void> get done` to SSHNP which completes when the SSHNP instance is no longer doing anything feat: added `allowed` property to SSHNPArg feat: added `sshClient` property to SSHNP; added 'ssh-client' to sshnp's params feat: bin/sshnp: now awaits sshnp.done if a non-failure result
… the github action output
fix: fix bug introduced during refactoring of authorized_keys file management: ensure sessionId is written to authorized_keys when adding ephemeral public keys fix: make ci work again, maybe?
…gher to eliminate dependency analysis warnings from version 3.3.7
… writing to authorized_keys refactor: rename `addPublicKeyToAuthorizedKeys` in common/utils.dart to `addEphemeralKeyToAuthorizedKeys` refactor: rename `removeFromAuthorizedKeys` in common/utils.dart to `removeEphemeralKeyFromAuthorizedKeys`
test: reverted test.sh
XavierChanth
previously approved these changes
Sep 11, 2023
…ag `add-forwards-to-tunnel` to the various SSHNP classes
…manually tested to prove it works
XavierChanth
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
--idle-timeoutfor tunnel connections--add-forwards-to-tunnelflag in sshnp)--ephemeral-permissionsoption on daemon to control what hosts and ports can be forwarded to on the forward tunnel connections (because the forward ssh tunnel connections use ephemeral keys and thus are constrained to be able to literally nothing other than connect, by default)--local-sshd-portoption to sshnpd for installations which are using non-standard sshd ports, and accordingly also added--remote-sshd-portoption to sshnp- How I did it
See messages on the individual commits in the PR
- How to verify it