Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: alternate_port_test, sshrvd healthcheck, prod_tests #468

Merged
merged 26 commits into from Sep 14, 2023

Conversation

JeremyTubongbanua
Copy link
Member

@JeremyTubongbanua JeremyTubongbanua commented Sep 13, 2023

- What I did

  • alternate_port_test now has condition: under its dependencies.. sometimes device name would not be shared
  • prod_tests now use env keys
  • alternate_port_test device name is more unique with a token
  • prod_tests device name is more unique with d token
  • prod_tests now has condition: for docker compose dependencies
  • setup-sshrvd-entrypoint refactored with template name
  • dockerfile image now uses ${HOMEDIR} instead of /atsign
  • we now use sshnp.log, sshnpd.log, sshrvd.log.
  • retries for healthcheck from 180 to 36. if it doesn't fail in 3 minutes, the service probably isn't working

- How I did it

- How to verify it

prod tests passing more consistently - https://github.com/atsign-foundation/sshnoports/actions/runs/6178173013/job/16770893463

image

- Description for the changelog

@JeremyTubongbanua
Copy link
Member Author

Sometimes health check wouldn't work https://github.com/atsign-foundation/sshnoports/actions/runs/6174606644/job/16759580194

sshnp container running even though monitor hasn't started for sshnpd
image

@JeremyTubongbanua JeremyTubongbanua changed the title refactor: prod tests refactor: prod test, image, and entrypoints Sep 13, 2023
@JeremyTubongbanua JeremyTubongbanua changed the title refactor: prod test, image, and entrypoints refactor: prod_tests, image, and entrypoints Sep 13, 2023
@JeremyTubongbanua
Copy link
Member Author

Sometimes health check wouldn't work https://github.com/atsign-foundation/sshnoports/actions/runs/6174606644/job/16759580194

sshnp container running even though monitor hasn't started for sshnpd image

reason why is I did not add condition: service_healthy under the dependencies
source: https://docs.docker.com/compose/startup-order/

@JeremyTubongbanua JeremyTubongbanua changed the title refactor: prod_tests, image, and entrypoints ci: alternate_port_test, sshrvd healthcheck, prod_tests Sep 13, 2023
@JeremyTubongbanua JeremyTubongbanua self-assigned this Sep 13, 2023
@JeremyTubongbanua JeremyTubongbanua marked this pull request as ready for review September 13, 2023 21:53
@XavierChanth
Copy link
Member

XavierChanth commented Sep 14, 2023

@JeremyTubongbanua can you re-run the (local, trunk) and make sure it builds before merging

@JeremyTubongbanua JeremyTubongbanua merged commit df33425 into trunk Sep 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants