chore: move ssh-client & legacy-daemon from core to cli only #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierChanth
commented
Nov 27, 2023
| params, | ||
| atClientGenerator: (SshnpParams params) => createAtClientCli( | ||
| homeDirectory: homeDirectory, | ||
| atsign: params.clientAtSign, | ||
| namespace: '${params.device}.sshnp', |
There was a problem hiding this comment.
This line got removed because this value is already set by SshnpCore
Sorry, missed a cast from String to the SupportedSshClient enum type. I explicitly typed where we extract those arguments from the ArgResults now, so we at least have some form of static analysis. |
gkc
reviewed
Nov 28, 2023
| @@ -106,12 +102,12 @@ class SshnpParams { | |||
| rootDomain: params2.rootDomain ?? params1.rootDomain, | |||
| localSshdPort: params2.localSshdPort ?? params1.localSshdPort, | |||
| listDevices: params2.listDevices ?? params1.listDevices, | |||
| legacyDaemon: params2.legacyDaemon ?? params1.legacyDaemon, | |||
| // legacyDaemon: params2.legacyDaemon ?? params1.legacyDaemon, | |||
gkc
reviewed
Nov 28, 2023
| remoteSshdPort: params2.remoteSshdPort ?? params1.remoteSshdPort, | ||
| idleTimeout: params2.idleTimeout ?? params1.idleTimeout, | ||
| addForwardsToTunnel: | ||
| params2.addForwardsToTunnel ?? params1.addForwardsToTunnel, | ||
| sshClient: params2.sshClient ?? params1.sshClient, | ||
| // sshClient: params2.sshClient ?? params1.sshClient, |
gkc
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
LGTM thanks @XavierChanth. FYI I pushed another commit to remove a couple of lines of dead commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #573
- What I did
- How I did it
- How to verify it
- Description for the changelog
chore: move ssh-client & legacy-daemon from core to cli only