Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added correct checks to ssh public key checks #636

Merged
merged 1 commit into from Dec 15, 2023

Conversation

cconstab
Copy link
Member

This might well be better in an extension of String or function call but as this does not change often this will solve the short term issue and we can raise an issue to clean up later

- What I did
Identified that sshnpd also checks the public key validity, and hence the -s still fails to work and so addressed the issue
- How I did it
I added the same RegEx checks in two different places in the code
- How to verify it
Really needs to built so it can be tested as there is not yet a -s end to end test
- Description for the changelog

Fixed issue where the public keys was being tested incorrectly by sshnpd when using the -s flag on sshnpd and sshnp

This might well be better in an extension of String or function call but as this does not change often this will solve the short term issue and we can raise an issue to clean up later
@XavierChanth XavierChanth merged commit 240591c into trunk Dec 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants