fix: added correct checks to ssh public key checks #636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might well be better in an extension of String or function call but as this does not change often this will solve the short term issue and we can raise an issue to clean up later
- What I did
Identified that sshnpd also checks the public key validity, and hence the
-s
still fails to work and so addressed the issue- How I did it
I added the same RegEx checks in two different places in the code
- How to verify it
Really needs to built so it can be tested as there is not yet a
-s
end to end test- Description for the changelog
Fixed issue where the public keys was being tested incorrectly by sshnpd when using the
-s
flag on sshnpd and sshnp