Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify review.php when "No Increase" remove the ability to vote. #5

Closed
GeeEssEff opened this issue Oct 20, 2017 · 8 comments
Closed
Milestone

Comments

@GeeEssEff
Copy link
Collaborator

No description provided.

@GeeEssEff
Copy link
Collaborator Author

relates to Issue #2

@GeeEssEff GeeEssEff added this to the Alpha milestone Nov 27, 2017
@jcjohnsonmo
Copy link
Collaborator

I think you've taken care of this one from what I see. The only thing I see that's related but not identical to this issue is that if all the symptoms are not AEs then that participant doesn't need to even show up in the list to be reviewed. For an example, see 711 (Participant A003).

@GeeEssEff
Copy link
Collaborator Author

That will be solved by the phase code. (if phase = NULL, if AE=Yes => phase 1, elseif AE=No => phase 0)

@GeeEssEff
Copy link
Collaborator Author

(will close with merge)

@jcjohnsonmo
Copy link
Collaborator

Ah. I see said the blind man as he picked up the hammer and saw.

@GeeEssEff
Copy link
Collaborator Author

Sorry.. the phase code checks each symptom before any jury member sees things. If it's not an AE then the symptom is marked as resolved (or phase = 0). If a patient has no AEs that are > 0 then the patient is marked as resolved (or phase = 0) so in main.php, you'll not see them.

If a patient has any symptoms that are unresolved (or phase > 0) they show up on main.php and all symptoms (regardless of their phase) are shown.)

@jcjohnsonmo
Copy link
Collaborator

Got it! So that's the code that still needs to be merged. 👍

@GeeEssEff
Copy link
Collaborator Author

Yes, the phase code is waiting on the rest of this to be completed before I can finish it.

GeeEssEff added a commit that referenced this issue Dec 5, 2017
Closes Issue #5
Closes Issue #17
Closes Issue #20
Fixes half of Issue #2 (the AE? flag) still needs work on the severity shifting part of things.
GeeEssEff added a commit that referenced this issue Dec 22, 2017
Closes Issue #5
Closes Issue #17
Closes Issue #20
Fixes half of Issue #2 (the AE? flag) still needs work on the severity shifting part of things.
GeeEssEff added a commit that referenced this issue Jul 10, 2018
Closes Issue #5
Closes Issue #17
Closes Issue #20
Fixes half of Issue #2 (the AE? flag) still needs work on the severity shifting part of things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants