Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_installation should check package versions #52

Closed
cscheid opened this issue Aug 6, 2013 · 4 comments
Closed

check_installation should check package versions #52

cscheid opened this issue Aug 6, 2013 · 4 comments
Assignees
@cscheid

Comments

@cscheid
Copy link

cscheid commented Aug 6, 2013

At the very least, it should try testing for a recent version of rgithub. Old versions of rgithub have been tripping quite a few people up.
@ghost ghost assigned cscheid Aug 6, 2013
@s-u
Copy link
Collaborator

s-u commented Aug 7, 2013

AFAICS the github package version has not changed despite dramatic API changes, so this is pretty much impossible to detect ...

@gordonwoodhull
Copy link
Contributor

D'oh! I'll take responsibility for that.

Maybe we should bump it now even if it's a bit late?

@s-u
Copy link
Collaborator

s-u commented Aug 7, 2013

Sure, that's perfectly fine - we can then require the new version.

@cscheid
Copy link
Author

cscheid commented Aug 8, 2013

Bug was with upstream rgithub, and now that it's fixed rcloud.support:::check.installation can do its magic. Closing.

@cscheid cscheid closed this as completed Aug 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cscheid cscheid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cscheid @gordonwoodhull @s-u