Fix for installing Swift4 branch from CocoaPods #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p swift-version file.
|
Oops! Thank you for tracking down this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current 'master' of SipHash uses a folder named 'sources' for the source code to SipHash. The swift4 branch now has that code in a folder named 'SipHash', but the podspec wasn't updated to reflect this. This caused 'pod install' of the swift4 branch to not download the Swift code for SipHash, making the pod not buildable.
This also prevented manual Podfile overrides of BigInt's SipHash dependency, as it would result in an invalid SipHash module.
Once this is merged, installing SipHash via Podfile will work on the Swift4 branch (allowing BigInt for swift4 to be compilable via a Podfile override).
Related BigInt issue: attaswift/BigInt#22