Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.0 violates semantic versioning #3

Closed
allewun opened this issue Sep 8, 2017 · 1 comment
Closed

v1.2.0 violates semantic versioning #3

allewun opened this issue Sep 8, 2017 · 1 comment

Comments

@allewun
Copy link

allewun commented Sep 8, 2017

The latest SipHash, 1.2.0, requires Swift 4.

The last version of BigInt to support Swift 3, v2.1.2, depended on SipHash ~> 1.1. This means that SipHash 1.2.0 is now being used by CocoaPods, which is incompatible and results in failed compilation.

Seems like v2.0.0 would've been a better version to use for this breaking change.


For those that are having the same issue with BigInt, just add SipHash explicitly to your Podfile. You can just specify pod 'SipHash', '1.1.2' to pin that version and prevent CocoaPods from implicitly choosing a higher version.

@koraykoska
Copy link
Collaborator

This violation was already made and we can't revert it as this would break even more projects. Also as of now most people are using Swift 4 and upwards anyways so it doesn't really matter. I'm closing this issue due to inactivity. If you have any other problems just open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants