-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bash): improve output of enter_accept
#1342
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
appreciate you sorting these both out! it's a shame fish/bash don't have anything like zle, but this is definitely an improvement |
No problem! These are unfortunately always going to be a bit of a hack, but they're close enough I think it's still worth keeping them in. |
this fix is important. Could you please consider doing at least a point release? thanks in advance. |
I know, and I am :D
…On Fri, 27 Oct 2023 at 16:02, Arturo Borrero Gonzalez < ***@***.***> wrote:
this fix is important. Could you please consider doing at least a point
release? thanks in advance.
—
Reply to this email directly, view it on GitHub
<#1342 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWYN3VLZ5QLO4QJ52VV6DTYBPEH5AVCNFSM6AAAAAA6SJ5XE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGA3DQMBUHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
thanks for your hard work in this project. It is really appreciated :-) |
For now, it is buggy, see atuinsh/atuin#1342 Signed-off-by: Arturo Borrero Gonzalez <arturo.bg@arturo.bg>
Very similar change to #1341, but for bash.
Bash's behavior here is worse than fish, as it only redraws the prompt line that has input (why we only need to add 1 additional line after the eval). It also does not show the prompt line at all on an echo. There's not really a way to get this to look normal AFAICT, aside from trying to redraw everything ourselves.
As an example, this is what running
ls
,echo here
, then selectingecho here
from the atuin menu will look like:1 line prompt:
2 line prompt: