Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: Misc improvements #1613

Merged
merged 2 commits into from Jan 24, 2024
Merged

stats: Misc improvements #1613

merged 2 commits into from Jan 24, 2024

Conversation

philn
Copy link
Contributor

@philn philn commented Jan 22, 2024

See commit messages :)

@philn philn changed the title stats: Misc improvement stats: Misc improvements Jan 22, 2024
ellie
ellie previously approved these changes Jan 23, 2024
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@ellie ellie enabled auto-merge (squash) January 23, 2024 18:59
@philn
Copy link
Contributor Author

philn commented Jan 24, 2024

What's up with the CI? :)

@philn
Copy link
Contributor Author

philn commented Jan 24, 2024

What's up with the CI? :)

Ah that looks related to my patch, I'll take a look.

An empty history shouldn't be source of error when printing stats.
It wasn't clear what the period format could be.
auto-merge was automatically disabled January 24, 2024 19:14

Head branch was pushed to by a user without write access

@philn philn requested a review from ellie January 24, 2024 19:14
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! thank you

@ellie ellie merged commit 079a078 into atuinsh:main Jan 24, 2024
16 checks passed
@philn philn deleted the stats-cli branch January 24, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants