Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prefers_reduced_motion flag #1645

Merged
merged 3 commits into from Feb 1, 2024
Merged

feat: add prefers_reduced_motion flag #1645

merged 3 commits into from Feb 1, 2024

Conversation

conradludgate
Copy link
Collaborator

Implementation of ideas discussed in #1290.

Can be enabled by setting either

  • PREFERS_REDUCED_MOTION=1
  • ATUIN_PREFERS_REDUCED_MOTION=1
  • prefers_reduced_motion = true in client config.

The implementation uses a custom now function, which is either OffsetDateTime::now_utc, or it uses a cached time value.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@ellie
Copy link
Member

ellie commented Jan 29, 2024

Looks good! Might be worth also adding NO_MOTION? I know it's technically not "none", but just to align with NO_COLOR

Not a standard or anything like the color one, but in case it does become one

ellie added a commit to atuinsh/docs that referenced this pull request Feb 1, 2024
@ellie ellie mentioned this pull request Feb 1, 2024
@ellie ellie merged commit 744f005 into main Feb 1, 2024
9 checks passed
@ellie ellie deleted the prefers-reduced-motion branch February 1, 2024 15:17
ellie added a commit to atuinsh/docs that referenced this pull request Feb 1, 2024
@ellie
Copy link
Member

ellie commented Feb 1, 2024

Thank you for this!

I wonder if we can end up with NO_MOTION implemented in a bunch of tools, like NO_COLOR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants