set durability for sqlite to recommended settings #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also do an optimize on connection close. Fixes lag on history insertion.
|
I'm hesitant due to
but I think that seems reasonable for now. once #1661 is complete we can do always change back to full with no issues. |
|
ref #952 |
|
Thank you so much! |
nebkor
added a commit
to nebkor/atuin
that referenced
this pull request
Mar 24, 2024
Just like atuinsh#1667, when connecting to a DB using WAL mode for journaling, the recommended setting for synchronizing the data "NORMAL", while the default is "FULL", which causes hangs on ZFS systems. The hangs are not as long or frequent as before atuinsh#1667, but are still present.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my ZFS system, commands were being blocked by history insertion due to
FULLdurability being enabled by default in SQLx for the WAL, sometimes for over a second, but at least half the time there was at least 500ms before the command was run. According to the documentation,NORMALis recommended.With this change, my terminal commands are no longer being blocked.
Checks