Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(import/zsh-histdb): missing or wrong fields #1740

Merged
merged 4 commits into from Feb 21, 2024
Merged

fix(import/zsh-histdb): missing or wrong fields #1740

merged 4 commits into from Feb 21, 2024

Conversation

Aloxaf
Copy link
Contributor

@Aloxaf Aloxaf commented Feb 20, 2024 •
edited

This PR do two things:

  1. Imports exit_status and session columns from zsh-histdb
  2. Converts duration to nanoseconds for importing

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@Aloxaf Aloxaf marked this pull request as draft February 20, 2024 10:49
@Aloxaf Aloxaf marked this pull request as ready for review February 20, 2024 11:28
@ellie
Copy link
Member

ellie commented Feb 20, 2024

Just a couple of comments

Are there any other fields we are missing?

@Aloxaf Aloxaf changed the title fix(import/zsh-histdb): import exit_status and session fix(import/zsh-histdb): missing or wrong fields Feb 20, 2024
@Aloxaf
Copy link
Contributor Author

Aloxaf commented Feb 20, 2024

Just a couple of comments

Thanks for your suggestions. I have updated my code.

Are there any other fields we are missing?

No more fields.
But I notice that duration should be measured in nanoseconds. Considering this is a minor bug, I also fixed it in this PR.

ellie
ellie approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie merged commit 21fee97 into atuinsh:main Feb 21, 2024
15 checks passed
@Aloxaf Aloxaf deleted the improve_histdb_improt branch February 21, 2024 12:07
@BrewTestBot BrewTestBot mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellie ellie ellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aloxaf @ellie