Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add config option keys.scroll_exits #1744

Merged
merged 3 commits into from Feb 21, 2024

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Feb 21, 2024

If the config option is set the false, using the up/down key won't exit the TUI when scrolled past the first/last entry.

Example:

[keys]
scroll_exits = false

The default is true, which is the current behavior.

/ref https://forum.atuin.sh/t/add-option-to-stop-down-arrow-exiting-search/94

fixes #922

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

If the config option is set the `false`, using the up/down key won't
exit the TUI when scrolled past the first/last entry.

Example:

```
[keys]
scroll_exits = false
```

The default is `true`, which is the current behavior.
@atuin-bot
Copy link

This pull request has been mentioned on Atuin Community. There might be relevant details there:

https://forum.atuin.sh/t/add-option-to-stop-down-arrow-exiting-search/94/9

Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config scroll_exists should also be mentioned in atuin-client/config.toml.

atuin/src/command/client/search/interactive.rs Outdated Show resolved Hide resolved
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Could we also get an update to the docs please? https://github.com/atuinsh/docs

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

@ellie ellie merged commit 56b971a into atuinsh:main Feb 21, 2024
15 checks passed
@tessus
Copy link
Contributor Author

tessus commented Feb 21, 2024

Could we also get an update to the docs please? https://github.com/atuinsh/docs

Sure, will do in a sec.

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this

I'd be delighted. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Make exit-on-down-arrow behavior optional
4 participants