feat(dotfiles): add enable setting to dotfiles, disable by default #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellie
force-pushed
the
ellie/dotfiles-settings
branch
2 times, most recently
from
2cc6d5d
to
44470e5
Compare
ellie
force-pushed
the
ellie/dotfiles-settings
branch
from
44470e5
to
1214056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it only costs a few ms, dotfiles is not yet as optimised as it should be. Running the whole store build is fast, but could be faster. I don't want to add the cost to all users, only those using dotfiles.
With a few hundred aliases set, building the alias list takes me around 20ms. Imo init should only be "read a prebuilt list", with no compute required.
Checks