Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow input of credentials from stdin #185

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

mozzieongit
Copy link
Contributor

This changes the arguments for register and login to be optional. If any arguments are not given, their content will be asked for interactively.

This was added, because command-line arguments are readable system-wide in the process list and end up in the history. (See #183)

Also: Great Project ^^

Closes: #183

@ellie
Copy link
Member

ellie commented Sep 24, 2021

If you could rebase this to pick up the clippy fixes then I can get it merged :)

Jannik Peters and others added 3 commits September 24, 2021 18:16
This changes the options for register to be optional. If arguments are
not given, the program will ask for them interactively.
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this :D

Also: Great Project ^^

Ty 💖

@ellie ellie enabled auto-merge (squash) September 24, 2021 16:22
@ellie ellie merged commit 27d3d81 into atuinsh:main Sep 24, 2021
@mozzieongit
Copy link
Contributor Author

It's a pleasure. :)
I was searching for a nice and small rust project to help with and learn more about rust. This is awesome. 🎉

@mozzieongit mozzieongit deleted the credentials-from-stdin branch September 24, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow credentials entry from stdin (interactively)
2 participants