Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KDE Neon #1909

Closed
dacog opened this issue Mar 29, 2024 · 1 comment
Closed

Add support for KDE Neon #1909

dacog opened this issue Mar 29, 2024 · 1 comment

Comments

@dacog
Copy link
Contributor

dacog commented Mar 29, 2024

Hi,

I'm using Atuin in several systems, and now I installed KDE Neon with Plasma 6 on a notebook and I noted that it tries to install from cargo.

I checked the install.sh script, and run some parts of if manually.

Because KDE Neon is based on Ubuntu 22.04, it should also use the .deb for Ubuntu IMHO), but the command

grep -Po '(?<=^ID=).*$' /etc/os-release | tr '[:upper:]' '[:lower:]'

returns "neon", which is not in the OS list in the script. I also tested installingthe .deb file available in Realeases manually without issues.

I added it and created a PR #1908

If I should change anything else, please let me know.

Best,

Diego

@ellie
Copy link
Member

ellie commented Apr 2, 2024

PR merged, thanks!

@ellie ellie closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants