Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh: log cargo and rustc version #2068

Merged
merged 1 commit into from
May 31, 2024
Merged

install.sh: log cargo and rustc version #2068

merged 1 commit into from
May 31, 2024

Conversation

xvello
Copy link
Contributor

@xvello xvello commented May 31, 2024

Issue #2031 is probably caused by an outdated rustc version.

The build should ideally fail with a better error message (is the workspace's rust-version lower than this dep's?), but in the meantime let's log both cargo and rustc versions to help with support.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@xvello xvello changed the title install: log cargo and rustc version install.sh: log cargo and rustc version May 31, 2024
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 😊

@ellie ellie merged commit 83637d9 into atuinsh:main May 31, 2024
14 checks passed
@xvello xvello deleted the patch-1 branch May 31, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants