Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibly a bug: install script broke my .zshrc #56

Closed
avinassh opened this issue May 8, 2021 · 3 comments
Closed

possibly a bug: install script broke my .zshrc #56

avinassh opened this issue May 8, 2021 · 3 comments

Comments

@avinassh
Copy link
Contributor

avinassh commented May 8, 2021

Hey there 馃憢 This is really a nice project and just like what I needed. I did the installation using the install script, at the end my ~/.zshrc ended up like this:

alias some_cmd="some args"eval "$(atuin init zsh)"

This happened because my earlier version must have not ended with a newline. May be I edited it and forgot to add a newline. I am happy to send a patch which manually adds a new line, but I was not so sure. Because this is not a bug if ~/.zshrc files are expected to ended with a newline. Also, I am not really sure how do other install scripts behave.

@ellie
Copy link
Member

ellie commented May 8, 2021

This is really a nice project and just like what I needed.

Thank you!

Because this is not a bug if ~/.zshrc files are expected to ended with a newline

Nope, this is totally a bug!

If you want to open a PR to fix this that would be awesome, otherwise I'll do it later today 馃槉

Thank you for reporting this!

@avinassh
Copy link
Contributor Author

avinassh commented May 8, 2021

@ellie sent :D

@conradludgate
Copy link
Collaborator

Solved in #60 馃帀 Thanks @avinassh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants