feat: add *Nushell* support

[stevenxxiu]

See NuShell support · Issue #687 · ellie/atuin.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
atuin	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 26, 2023 at 6:02AM (UTC)

[ellie]

I'll give this a proper test and review tomorrow! Thank you 🙏

[ellie]

Couple of comments - I'm going to install nu now as well, just to get a bit of history

[conradludgate]

Code looks good. I'll have a test soon and see how it feels. Thank you so much ❤️

[stevenxxiu]

Rebased due to Add history deletion by ellie · Pull Request #791 · ellie/atuin.

[ellie]

Testing this on my machine atm - it looks like perhaps new history items aren't being stored OK? I'm running commands and nothing is stored, though I am occasionally seeing blank entries. Perhaps the precmd is running OK but post command is not? I'm running nu 0.77.1 so I think that should be ok

And also, the up arrow binding is not bound by default - would be awesome to get the behaviour matching our defaults elsewhere!

Otherwise everything is super smooth, thank you!

[stevenxxiu]

Oh you need 0.77.2 as don't think 0.77.1 includes my hook PR.

Sure I can include the up arrow keybind too. Good idea.

[ellie]

Ah! That explains it 😂 I'll sort that now!

[stevenxxiu]

I don't actually think getting the edit buffer is currently possible and pass it to Atuin, due to the Nushell having trouble piping stderr:

• The complete command doesn't work with interactive commands · Issue #8539 · nushell/nushell
• Redirect stderr · Issue #8277 · nushell/nushell

So can't bind the up arrow key. This PR now just allows searching in Atuin, without getting input from the edit buffer.

[stevenxxiu]

Actually let me see if I can hack around this a bit. Maybe I can use Sh to swap stdout and stderr.

[stevenxxiu]

Actually let me see if I can hack around this a bit. Maybe I can use Sh to swap stdout and stderr.

This seems doable, but an even bigger problem is that I'm not sure how and if it's possible to get the current input buffer's contents, in a executehostcommand. I'm asking Nushell people about this.

[stevenxxiu]

Requires my PR nushell/nushell#8560.

[ellie]

Hey @stevenxxiu! Is this ready for a review? 🙏 I'll need to run NuShell master to test this, right?

[stevenxxiu]

@ellie Yup it should be. I'm guessing Nushell master is the easiest. Personally I'm just running v0.77.2 with a few patches including this one. Thanks! ❤️

[fdncred]

Hi! I'm one of the nushell maintainers. I'm excited to use nushell with atuin. However, it breaks my heart a little to see it not be cross platform because of this one part.

def _atuin_search_cmd [...flags: string] {
    [
        $ATUIN_KEYBINDING_TOKEN,
        ([
            `commandline (sh -c 'RUST_LOG=error atuin search `,
            $flags,
            ` -i -- "$0" 3>&1 1>&2 2>&3' (commandline))`,
        ] | flatten | str join ''),
    ] | str join "\n"
}

Can you help me understand the technical reason why this needs to happen? I'm not a regular bash user but I think this is swapping stderr and stdout, but tbh, I'm not positive. Is there something that nushell could do to help make this work better?

[stevenxxiu]

@fdncred Yes this is just swapping stderr and stdout. I believe the interface is on stdout, and the command that's selected goes to stderr. This gets swapped so stdout contains the command that's selected.

From my point of view these two issues need to be addressed:

• The complete command doesn't work with interactive commands · Issue #8539 · nushell/nushell
• Redirect stderr · Issue #8277 · nushell/nushell

[fdncred]

@stevenxxiu is it also true that if atuin could control where the output gets places (stdout vs stderr), via a parameter, then there wouldn't be a need for this?

I'll ask around to see if anyone has ideas about how to make this work in nushell (specifically the issues you linked). TBH, I don't think nushell has our stderr, stdout story all sorted out, it's not very user friendly and accessible right now. It's somewhat difficult work.

[conradludgate]

I'll test if we can switch them in other shells to make things easier.

Edit: looks like we can with zsh and bash and fish

[ellie]

LGTM! Thank you so much for this!!! 🙏 Really appreciate the work you have done on both sides.

I'm not sure how well this will work on Windows (and on which terminals/setups it will work), but we don't claim solid Windows support either way - especially given how fresh thast support is.

[happysalada]

thanks a lot for this, I've just tested this and ran into a small error
#841
happy to provide more feedback and/or test anything.