Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow nix package to fetch dependencies from git #832

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

arcuru
Copy link
Sponsor Contributor

@arcuru arcuru commented Mar 30, 2023

This change saves us from needing to keep a copy of the checksum in atuin.nix, so that Cargo.lock can remain as the sole source of truth for the dependency versions.

This fixes the nix build, as it currently fails because the ratatui dep is fetched from Conrad's git repo instead of the registry. I also added some comments to help maintain the package.

This change saves us from needing to keep a copy of the checksum in atuin.nix, so that Cargo.lock can remain as the sole source of truth for the dependency versions.
@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
atuin ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 5:29PM (UTC)

@ellie ellie merged commit 662f2b8 into atuinsh:main Mar 31, 2023
6 checks passed
@arcuru arcuru deleted the nix-package-fetch branch October 26, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants