Add graceful shutdown on SIGTERM#1014
Merged
conradludgate merged 2 commits intoatuinsh:mainfrom May 30, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
conradludgate
approved these changes
May 30, 2023
Collaborator
|
Perfect, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #676
This is my first significant exposure to Rust in general, especially async. I had to learn a lot of background for these few lines of code lol
Anyways, I tested it with a local docker-compose.yml and it seems to be working
(working = it does not wait anymore for the timeout and SIGKILL, but it shuts down seemingly immediately with a corresponding message and exit code 0).
Further tests are welcome!