Add support to override hostname and username via env vars#1041
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ellie
previously approved these changes
Jun 12, 2023
auto-merge was automatically disabled
June 12, 2023 16:33
Head branch was pushed to by a user without write access
lugoues
force-pushed
the
add_host_user_env_overrides
branch
from
4fb016f to
23059b3
Compare
Contributor
Author
|
Formatting :'( |
conradludgate
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to set
ATUIN_HOST_NAMEandATUIN_HOST_USERas a means of overriding the default values from the system calls. I found that controlling the hostname and user when using devcontainers in a container was extremely tedious and this will help a great deal in controlling how things are persisted in atuin.I chose the names
ATUIN_HOST_NAMEandATUIN_HOST_USERto try to avoid confusion with a user's atuin username, but if anyone has any recommendations I'd be more than happy to change them.