Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record encryption #1058

Merged
merged 12 commits into from Jun 26, 2023
Merged

record encryption #1058

merged 12 commits into from Jun 26, 2023

Conversation

conradludgate
Copy link
Collaborator

@conradludgate conradludgate commented Jun 18, 2023

Using a combination of V4 PASETO/PASERK with randomized wrapped keys to encrypt the data of each record.

I've used a set of DecryptedData/EncryptedData types to ensure that we don't mistakenly write decrypted data to the database

TODO:

  • record tag+version -> PASETO version
  • consider migrating the database to use a string for the data row instead of bytes

@vercel
Copy link

vercel bot commented Jun 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 11:10am

Co-authored-by: Matteo Martellini <matteo@mercxry.me>
Co-authored-by: Matteo Martellini <matteo@mercxry.me>
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! Just the spelling error and we're good

atuin-common/src/record.rs Outdated Show resolved Hide resolved
@ellie ellie merged commit 6c53242 into main Jun 26, 2023
9 checks passed
@ellie ellie deleted the record-encryption branch June 26, 2023 06:52
ealap pushed a commit to ealap/atuin that referenced this pull request Jun 29, 2023
* record encryption

* move paserk impl

* implicit assertions

* move wrapped cek

* add another test

* use host

* undo stray change

* more tests and docs

* fmt

* Update atuin-client/src/record/encryption.rs

Co-authored-by: Matteo Martellini <matteo@mercxry.me>

* Update atuin-client/src/record/encryption.rs

Co-authored-by: Matteo Martellini <matteo@mercxry.me>

* typo

---------

Co-authored-by: Matteo Martellini <matteo@mercxry.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants