New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record encryption #1058
Merged
Merged
record encryption #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
conradludgate
force-pushed
the
record-encryption
branch
from
June 19, 2023 23:45
b807e03
to
57d9f9e
Compare
This was referenced Jun 20, 2023
Closed
Closed
mercxry
reviewed
Jun 20, 2023
Co-authored-by: Matteo Martellini <matteo@mercxry.me>
mercxry
reviewed
Jun 20, 2023
Co-authored-by: Matteo Martellini <matteo@mercxry.me>
ellie
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! Just the spelling error and we're good
ellie
approved these changes
Jun 26, 2023
ealap
pushed a commit
to ealap/atuin
that referenced
this pull request
Jun 29, 2023
* record encryption * move paserk impl * implicit assertions * move wrapped cek * add another test * use host * undo stray change * more tests and docs * fmt * Update atuin-client/src/record/encryption.rs Co-authored-by: Matteo Martellini <matteo@mercxry.me> * Update atuin-client/src/record/encryption.rs Co-authored-by: Matteo Martellini <matteo@mercxry.me> * typo --------- Co-authored-by: Matteo Martellini <matteo@mercxry.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a combination of V4 PASETO/PASERK with randomized wrapped keys to encrypt the data of each record.
I've used a set of
DecryptedData
/EncryptedData
types to ensure that we don't mistakenly write decrypted data to the databaseTODO: