Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Teapot is a cup of coffee #1137

Merged
merged 1 commit into from Jul 31, 2023
Merged

fix(server): Teapot is a cup of coffee #1137

merged 1 commit into from Jul 31, 2023

Conversation

LeoniePhiline
Copy link
Contributor

@LeoniePhiline LeoniePhiline commented Jul 31, 2023 •
edited

The fallback route handler teapot() responded with HTTP 418 responses with an invalid response body "☕".

This PR fixes this urgent issue by replacing the response body with an actual teapot "🫖".

ellie
ellie approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, of course! Thank you 😊

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie enabled auto-merge (squash) July 31, 2023 17:15
@ellie ellie merged commit 73da976 into atuinsh:main Jul 31, 2023
8 checks passed
@LeoniePhiline
Copy link
Contributor Author

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

Wow, yeah! How cool! 💜💜

@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellie ellie ellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeoniePhiline @ellie