Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update(docs) Add workspace to config.toml and config.md #1157

Merged
merged 1 commit into from Aug 9, 2023
Merged

Update(docs) Add workspace to config.toml and config.md #1157

merged 1 commit into from Aug 9, 2023

Conversation

thePanz
Copy link
Contributor

@thePanz thePanz commented Aug 8, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 11:47am

@ellie
Copy link
Member

ellie commented Aug 8, 2023

Thank you for sorting this out! The docs do need some attention...

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie merged commit 8080a17 into atuinsh:main Aug 9, 2023
10 checks passed
@thePanz thePanz deleted the add-workspace-documentation branch August 10, 2023 06:50
@Adda0
Copy link
Contributor

Adda0 commented Nov 3, 2023

Should the config key be workspace, or workspaces? Both options are used at different places in the documentation (config.toml uses workspaces (the correct one) and documentation uses workspace). Both should be unified to workspaces, no?

@thePanz
Copy link
Contributor Author

thePanz commented Nov 3, 2023

@Adda0 this was already fixed in #1174
My bad introducing a typo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants