feat(keyup): Configure SearchMode for KeyUp invocation #1216

[deicon]

Adding another config option to setup Search Mode on KeyUp invocations.
Fixing #1216

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
atuin-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 17, 2023 5:37pm

[deicon]

@ellie not sure about the review process here, but PRs seem to be alive quite a bit.
Do you need some more Info for this PR to ease the review ?

Awesome tool by the way :-) appreciate your work here.

[ellie]

All good! I was halfway through testing your PR but then had to start work 🤣

It didn't quite work on my setup, but mine is pretty non standard. I'll get some time to finish the review over the weekend

But thank you, glad you like Atuin! And thank you for taking the time to contribute

[deicon]

Updated the documentation as seen in this PR #1235 which seems to be a copy of this one here.

[bretthoerner]

I have a dupe PR up, and my guess as to why this didn't work for Ellie is that you need to change the engine: https://github.com/atuinsh/atuin/pull/1235/files#diff-8ef1f8bf3ed66b4786b6e33de018a22448799f64470de843ce9c7653e69b5eddR645

[deicon]

@bretthoerner thanks for the catch. Which makes our PRs identical :)
Funny though, that I made this first, and we still came up with almost identical code 👍 As I am using this as a means of learning Rust, I take this as a good sign, that I am on track :)

[ellie]

It'll just need a cargo fmt and should be good to go! There's also an issue that clippy has raised

[deicon]

fmt and clippy fixed.
@ellie you enabled Automerge but did not approve yet.