Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear history id #1263

Merged
merged 3 commits into from Oct 8, 2023
Merged

clear history id #1263

merged 3 commits into from Oct 8, 2023

Conversation

conradludgate
Copy link
Collaborator

  1. s/RUST_LOG/ATUIN_LOG/ for all shells (cc Switch to using ATUIN_LOG instead of RUST_LOG #642)
  2. unset ATUIN_HISTORY_ID for all shells (fixes Time of last-run command can be wrong (now instead of actual) #1261)
  3. Add trace log for the running command

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 4:00pm

@conradludgate
Copy link
Collaborator Author

tested in bash, need to test all the other shells that the syntax works.

It seems that in bash the preexec doesn't run if there's no command, but the precmd does run. Fun!

ellie
ellie previously approved these changes Sep 28, 2023
@ellie
Copy link
Member

ellie commented Oct 7, 2023

@conradludgate are we good to merge this one soon?

@conradludgate
Copy link
Collaborator Author

Ah, I was meaning to test other shells

@conradludgate conradludgate merged commit 38172f3 into main Oct 8, 2023
10 checks passed
@conradludgate conradludgate deleted the clear-history-id branch October 8, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time of last-run command can be wrong (now instead of actual)
2 participants