Skip to content

Add enter_accept to immediately execute an accepted command#1311

Merged
ellie merged 6 commits into
mainfrom
ellie/exec
Oct 20, 2023
Merged

Add enter_accept to immediately execute an accepted command#1311
ellie merged 6 commits into
mainfrom
ellie/exec

Conversation

@ellie
Copy link
Copy Markdown
Member

@ellie ellie commented Oct 19, 2023

enter_accept will make Atuin immediately accept an execute a command
when selected. It defaults to false in our binary, but the default
config enables it.

This means that users who already use atuin will not default to the new
behaviour unless they opt in, but new users will have it by default.

Thanks to @davidhewitt for the patch and bulk of this implementation!
Currently we have it just for zsh, but I'll follow up with other shells
(unless anyone beats me to it :D)

This also uses "tab" to select and edit a command

davidhewitt and others added 3 commits October 19, 2023 20:15
enter_accept will make Atuin immediately accept an execute a command
when selected. It defaults to false in our binary, but the default
config enables it.

This means that users who already use atuin will not default to the new
behaviour unless they opt in, but new users will have it by default.

Thanks to @davidhewitt for the patch and bulk of this implementation!
Currently we have it just for zsh, but I'll follow up with other shells
(unless anyone beats me to it :D)
@ellie ellie requested a review from conradludgate October 19, 2023 19:44
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 6:17am

@ellie
Copy link
Copy Markdown
Member Author

ellie commented Oct 19, 2023

Comment thread atuin/src/command/client/search/interactive.rs
conradludgate
conradludgate previously approved these changes Oct 20, 2023
Comment thread docs/docs/config/config.md Outdated
Co-authored-by: Conrad Ludgate <conradludgate@gmail.com>
@ellie
Copy link
Copy Markdown
Member Author

ellie commented Oct 20, 2023

@davidhewitt thanks again for this! If you fancy a shiny contributor-only sticker in the post, please fill out this form!

@davidhewitt
Copy link
Copy Markdown
Contributor

Thanks! Not sure I did a huge amount, but I filled out the form anyway 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants