Skip to content

fix(import/zsh-histdb): missing or wrong fields - #1740

Merged
ellie merged 4 commits into
atuinsh:mainfrom
Aloxaf:improve_histdb_improt
Feb 21, 2024
Merged

fix(import/zsh-histdb): missing or wrong fields#1740
ellie merged 4 commits into
atuinsh:mainfrom
Aloxaf:improve_histdb_improt

Conversation

@Aloxaf

@Aloxaf Aloxaf commented Feb 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR do two things:

  1. Imports exit_status and session columns from zsh-histdb
  2. Converts duration to nanoseconds for importing

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@Aloxaf
Aloxaf marked this pull request as draft February 20, 2024 10:49
@Aloxaf
Aloxaf marked this pull request as ready for review February 20, 2024 11:28
ellie
ellie reviewed Feb 20, 2024
View reviewed changes
Comment thread atuin-client/src/import/zsh_histdb.rs Outdated
ellie
ellie reviewed Feb 20, 2024
View reviewed changes
Comment thread atuin-client/src/import/zsh_histdb.rs Outdated
@ellie

ellie commented Feb 20, 2024

Copy link
Copy Markdown
Member

Just a couple of comments

Are there any other fields we are missing?

@Aloxaf Aloxaf changed the title fix(import/zsh-histdb): import exit_status and session fix(import/zsh-histdb): missing or wrong fields Feb 20, 2024
@Aloxaf

Aloxaf commented Feb 20, 2024

Copy link
Copy Markdown
Contributor Author

Just a couple of comments

Thanks for your suggestions. I have updated my code.

Are there any other fields we are missing?

No more fields.
But I notice that duration should be measured in nanoseconds. Considering this is a minor bug, I also fixed it in this PR.

ellie
ellie approved these changes Feb 21, 2024
View reviewed changes

@ellie ellie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie
ellie merged commit 21fee97 into atuinsh:main Feb 21, 2024
@Aloxaf
Aloxaf deleted the improve_histdb_improt branch February 21, 2024 12:07
@BrewTestBot BrewTestBot mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellie ellie ellie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aloxaf @ellie