Bug/fix gh action aarch64 tarball #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey! Thank you for working on this!
It would be nice to solve this 🤔 Maybe we should virtualize ARM for generating completions? |
|
got it. I will give it a try to fix this. |
…ore gen-completions
m2nx
force-pushed
the
bug/fix-gh-action-aarch64-tarball
branch
from
920a88f
to
cd4dca1
Compare
|
plz let me know if there is any issue. |
|
Hi @ellie is there anything else I can do about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is going to fix a bug that github action will not create aarch arm64 tar file correctly.
you can see the error here https://github.com/ellie/atuin/actions/runs/4584398463/jobs/8095857446
how to fix
the first commit will fix this problem. just add a RUSTFLAGS to set linker aarch64-linux-gnu-gcc
RUSTFLAGS=-C linker=aarch64-linux-gnu-gccthe second commit is to bypass generate completion job because you can't run arm format on a Github hosted runner which is x86-64. we need to discuss how to fix the completion file.
here's result:
FYI:
https://crates.io/crates/grb/1.3.0
https://users.rust-lang.org/t/unable-to-compile-to-aarch64-unknown-linux-gnu/53517