Don't advance the epoch in try_collect until after doing the collection. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In try_collect(), it is important to reclaim memory from two epochs ago *before* advancing the local epoch. As soon as the local epoch has been advanced, another thread could advance the epoch and start putting garbage in that same bag. Closes #46.
|
Thanks so much for tracking this down! |
aturon
added a commit
that referenced
this pull request
Feb 9, 2016
Don't advance the epoch in try_collect until after doing the collection.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In try_collect(), it is important to reclaim memory from two epochs
ago before advancing the local epoch. As soon as the local epoch has
been advanced, another thread could advance the epoch and start
putting garbage in that same bag.
Closes #46.