Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbox.js #8

Closed
dav-is opened this issue Oct 6, 2017 · 3 comments
Closed

Workbox.js #8

dav-is opened this issue Oct 6, 2017 · 3 comments
Assignees
Projects

Comments

@dav-is
Copy link
Contributor

dav-is commented Oct 6, 2017

It appears you are using custom service worker code? Maybe using workbox.js would make for a longer term solution as it is being actively maintained, so you wouldn't need to worry about it.

Also, don't take my many issues I've opened as disrespect. I appreciate the work you've done and think you've done a much better job than a lot of the other boilerplates.

Thanks,
Davis

@tirthbodawala
Copy link
Member

@dav-is I don't know if you understand, but your contribution is In-Valuable to the project. Informing about improvements is something we really really appreciate. Your name has been echoing in the office from past 2 days.
You are the Hero of knowledge @ Atyantik :) Please keep up the great contribution.

@tirthbodawala tirthbodawala added this to Todo in Avengers Oct 7, 2017
@tirthbodawala tirthbodawala self-assigned this Oct 7, 2017
@tirthbodawala
Copy link
Member

@dav-is We have used our custom logic as we are proving more functionality than workbox.js at the moment, which include local caching, custom API request caching. I think we can find a workaround to include workbox.js in upcoming milestones. but as of now as I go through their documentation we have covered most of the part.

@tirthbodawala
Copy link
Member

@dav-is We have implemented workbox-sw but as a lib in core. We were unable to make it functional via
yarn add due to the following issue
GoogleChrome/workbox#352

But once its solved we shall move it to node_modules again.

@tirthbodawala tirthbodawala moved this from Todo to Done in Avengers Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants