Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double bullet being rendered in README #84

Merged
merged 2 commits into from
Apr 25, 2018
Merged

Fix double bullet being rendered in README #84

merged 2 commits into from
Apr 25, 2018

Conversation

thewarpaint
Copy link
Contributor

No description provided.

@auchenberg auchenberg self-assigned this Feb 28, 2018
auchenberg
auchenberg reviewed Feb 28, 2018
View reviewed changes
README.md Outdated
@@ -66,7 +66,7 @@ CI servers detected:
- [TaskCluster](http://docs.taskcluster.net)
- [GoCD](https://www.go.cd/)
- [Bitbucket Pipelines](https://bitbucket.org/product/features/pipelines)
- + all other CI servers that exposes a `CI` or `CONTINUOUS_INTEGRATION`
- and all other CI servers that exposes a `CI` or `CONTINUOUS_INTEGRATION`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like to keep the + in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, changed it.

auchenberg
auchenberg reviewed Mar 2, 2018
View reviewed changes
Copy link
Owner

@auchenberg auchenberg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a test

auchenberg
auchenberg reviewed Mar 14, 2018
View reviewed changes
README.md
@@ -66,7 +66,7 @@ CI servers detected:
- [TaskCluster](http://docs.taskcluster.net)
- [GoCD](https://www.go.cd/)
- [Bitbucket Pipelines](https://bitbucket.org/product/features/pipelines)
- + all other CI servers that exposes a `CI` or `CONTINUOUS_INTEGRATION`
- \+ all other CI servers that exposes a `CI` or `CONTINUOUS_INTEGRATION`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a line comment

watson
watson approved these changes Mar 15, 2018
View reviewed changes
Copy link
Collaborator

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The escaped + seems to render fine now 👍

@watson
Copy link
Collaborator

watson commented Mar 15, 2018

The test failures are unrelated. I just fixed them in master

@thewarpaint
Copy link
Contributor Author

Any news on this PR? Otherwise I would close it.

@watson watson merged commit 5383161 into auchenberg:master Apr 25, 2018
@watson
Copy link
Collaborator

watson commented Apr 25, 2018

Thanks for helping out 😃

@thewarpaint thewarpaint deleted the patch-1 branch April 25, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auchenberg auchenberg auchenberg left review comments

@watson watson watson approved these changes

Assignees

@auchenberg auchenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thewarpaint @watson @auchenberg