Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple acservice package and service integration tests from mediator #18

Closed
ffont opened this issue Apr 14, 2017 · 0 comments
Closed
Assignees

Comments

@ffont
Copy link
Member

ffont commented Apr 14, 2017

Currently the acservice package is provided as part of the Audio Commons Mediator.
New third party services are expected to be added to the ecosystem by implementing a "service plugin" using the acservice package. To facilitate this, acservice should be provided as a package completely separated from Audio Commons Mediator (should also be in a different repo).

Dependencies form the acservice package to the rest of the mediator should therefore be eliminated. If I'm not wrong these dependencies are only exception classes.

Also, the service integration testing functionality should be separated from the mediator and probably provided as a script in acservice package which might generate an output html file with test results (or output to console). Then the service integration testing part of the mediator can be eliminated as won't be really required there.

Services configuration should also be decoupled from the mediator and config parameters should be loaded from a file per service.

@ffont ffont added this to the First public milestone Oct 6, 2017
@ffont ffont self-assigned this Oct 6, 2017
ffont added a commit that referenced this issue Dec 5, 2017
ffont added a commit that referenced this issue Dec 5, 2017
@ffont ffont closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant