Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking not working.. #26

Closed
mmichalowicz opened this issue Nov 29, 2017 · 1 comment
Closed

Masking not working.. #26

mmichalowicz opened this issue Nov 29, 2017 · 1 comment

Comments

@mmichalowicz
Copy link

I used the log4j2.xml and test Java code for a simple CONFIDENTIAL log from the src/test/resources and src/test/java/...MaskingRewritePolicyTest.java. Only thing that looks out of place:

2017-11-28 23:18:20,692 main WARN Log4j does not support detached Markers. Returned Marker [CONFIDENTIAL] will be unchanged.

log4j-api: 2.10.0
log4j-core: 2.10.0
log4j-slf4j-impl: 2.10.0
security-logging-log4j: 1.1.3
security-logging: 1.1.3

Smells like a versioning issue. I'd love to be able to recommend my employer use this logger and masking would be nice. I don't see any documentation on "packages" in the but I added the package of the MaskingRewritePolicy.java... I'm certain I am using parameters.

@augustd
Copy link
Owner

augustd commented Nov 30, 2017

This is a normal warning, see: https://stackoverflow.com/questions/22745221/slf4j-what-is-a-dangling-or-detached-marker

The masking is unaffected. For example, in the test the following line prints out with the SSN masked as it should:

09:47:50.789 CONFIDENTIAL [main] INFO org.owasp.security.logging.log4j.mask.MaskingRewritePolicyTest - ssn=********

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants