Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish nuget package that contains .NET Core 3.1 assemblies #20

Closed
Insire opened this issue Nov 5, 2020 · 6 comments
Closed

Publish nuget package that contains .NET Core 3.1 assemblies #20

Insire opened this issue Nov 5, 2020 · 6 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@Insire
Copy link

Insire commented Nov 5, 2020

Hi,

i noticed that you merged and pushed support for .NET Core 3.1 here on github. It would be great, if the official nuget package would reflect that support aswell. Right now, there are only .NET 4.5 assemblies in there. Which causes a warning when restoring and building a project with that version.

Your package on fuget.

What i get when i download the package manually:
grafik

Then warning in question:

3>E:\Code\Maple\src\Maple\Maple.csproj : warning NU1701: Package 'Ookii.Dialogs.Wpf 1.2.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.

My project targets <TargetFrameworks>netcoreapp3.1</TargetFrameworks>

@augustoproiete augustoproiete self-assigned this Nov 5, 2020
@augustoproiete augustoproiete added this to the 2.0.0 milestone Nov 5, 2020
@augustoproiete augustoproiete added the question Further information is requested label Nov 5, 2020
@augustoproiete
Copy link
Member

Hey @Insire, yes I did all those things you mentioned, last night, but just in a different order... I released Ookii.Dialogs v1.2.0 first, from the master branch which contains a number of features that made in before the .NET Core 3.1 merge into the develop branch which is still a work-in-progress.

Support for .NET Core 3.1 will come in a few days as version 2.0.0 and I'll release at least one pre-release package (#5) before the final 2.0.0 release, probably over the weekend.

@Insire
Copy link
Author

Insire commented Nov 5, 2020

i'll be patient then. :)

@augustoproiete
Copy link
Member

@Insire, the Ookii.Dialogs.Wpf 2.0.0-preview1 has been published on nuget.org

Install-Package Ookii.Dialogs.Wpf -Version 2.0.0-preview1

Please test in your apps and report any issues you find.


Thanks to @acemod13 for doing all the work!

@Insire
Copy link
Author

Insire commented Nov 13, 2020

Hi,

thx for the update. With the new preview version the warning is gone and the VistaOpenFileDialog seems to be working as expected. Thx!

@Insire Insire closed this as completed Nov 13, 2020
@augustoproiete
Copy link
Member

@Insire, the stable version with .NET 3.1 support has been published to nuget.org: Ookii.Dialogs.Wpf 2.0.0

Install-Package Ookii.Dialogs.Wpf -Version 2.0.0

N.B.: WPF apps on .NET Core 3.1 need to declare an application manifest in order to use Ookii Dialogs. The manifest was added automatically in .NET Framework apps, but with .NET Core 3.1 this is no longer the case, so there's a little extra step that the developer needs to do. More details on the README of this repo.


Thanks again to @acemod13 for the contribution!

@Insire
Copy link
Author

Insire commented Nov 15, 2020

I'll keep that in mind. Thanks for the update and your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

2 participants