Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed XPThemes.manifest in the assembly to resolve EntryPointNotFoundException #31

Closed
augustoproiete opened this issue Nov 24, 2020 · 0 comments · Fixed by #33
Closed
Labels
enhancement New feature or request
Milestone

Comments

@augustoproiete
Copy link
Member

augustoproiete commented Nov 24, 2020

.NET Core 3.1 and .NET 5 apps using Ookii.Dialogs currently need to add an app.manifest file with a reference to Microsoft.Windows.Common-Controls to the application. Without the manifest the user gets an EntryPointNotFoundException.

image

This was not a requirement for .NET Framework apps because Microsoft included the XPThemes.manifest together with the .NET Framework, but stopped including it with .NET Core and didn't include it with .NET 5 either.

Let's add the XPThemes.manifest file as an embedded resource to Ookii Dialogs assembly and load it from the resources moving forward, thus removing the dependency on the file being part of the .NET installation, which is the same approach that Windows Forms is using when running as single-file.


This invalidates #30 as we won't have the EntryPointNotFoundException anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
1 participant