Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL #70

Closed
wbshaw opened this issue Oct 23, 2023 · 3 comments
Closed

SSL #70

wbshaw opened this issue Oct 23, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@wbshaw
Copy link

wbshaw commented Oct 23, 2023

Is there any option to add SSL?
Reason being - when the link gets shared over WhatsApp, even if the link is http:// when it is clicked on it opens as https:// and the user just gets an error until they manually edit the URL.

@aunefyren
Copy link
Owner

Hey, by adding SSL, do you mean an option to install a certificate?

HTTP->HTTPS redirection is not really done by Wrapperr, and is typically executed by the DNS provider, proxy service or by the app/site opening the link. The exception however is two ports. If you are using port 80, many browsers will assume HTTP, at 443 they will assume HTTPS. I can open a HTTP link like this http://192.168.1.1:8282/ and the site loads.

People hosting open source applications, which they want to share outside their own network, typically utilize a reverse proxy for simplicity, security and certificate management. Options like Nginx, Traefik and Cloudflare tunnels allow you to share services with automatic certificate-retrieval from providers like Let's Encrypt and Cloudflare.

Because of reverse proxies, many projects don't bother with certificate options, as this can be done by the reverse proxy.

@wbshaw
Copy link
Author

wbshaw commented Oct 24, 2023

Yeah - to be able to add a certificate essentially, just so that one is presented should a user get forced over https.

Just to clarify the issue I had with mobile users:

  1. Link is sent to users in WhatsApp as http://mywrapperrurl:8282
  2. User clicks on the link from WhatsApp (which still shows as http://mywrapperrurl:8282)
  3. Link opens in Chrome Android but as https://mywrapperrurl:8282
  4. Generic SSL Invalid response error is shown (as there is no SSL on that endpoint) - User has to manually edit the URL to remove the 's' from https

I will look into a reverse proxy, but haven't bothered yet as haven't really needed. Appreciate this is an external problem for you and really is to do with WhatsApp and Android/Chrome, but couldn't find any detail on it as to why it happens.

@aunefyren aunefyren added the enhancement New feature or request label Oct 25, 2023
@aunefyren
Copy link
Owner

Fixed in v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants