Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken compatibility with Burn My Windows on Wayland if fractional scaling is off #530

Closed
FelixFourcolor opened this issue Feb 21, 2024 · 3 comments

Comments

@FelixFourcolor
Copy link

(continuation of #528)

Another consequence of commit e242657 (PR #522) is that when fractional scaling is off, Burn My Windows applies its affect at the wrong area.

Without e242657 (pre-v55), the effect is applied exactly on top of the window: screencast

With e242657 (v55), the effect overflows the window boundary: screencast. The overflow part looks like the overflow blur box as described in #528, I assume it's not a coincidence.

I only show in the screencasts one of Burn My Windows' many effects, but in my testing I find most - if not all of them - are similarly broken.

After testing I find the same situation as in #528:

With e242657 Without e242657
Fractional scaling on working broken (#362)
Fractional scaling off broken (this issue) working
@aunetx
Copy link
Owner

aunetx commented Feb 24, 2024

Working on this :)

@aunetx
Copy link
Owner

aunetx commented Feb 24, 2024

Uh, actually not really, working on #528 but I guess once it's solved this bug will be too, as Burn my Windows simply takes the blur effect into account in its frame rectangle calculation

@aunetx
Copy link
Owner

aunetx commented Feb 24, 2024

This should be fixed by #534, waiting for some testing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants