Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions seems to remove CNAME from pages settings and 404s #53

Closed
krisnova opened this issue Oct 18, 2022 · 7 comments
Closed

GitHub actions seems to remove CNAME from pages settings and 404s #53

krisnova opened this issue Oct 18, 2022 · 7 comments
Labels
Good First Issue New to the project? Looking for something to get started with? Ops Pre or Post, we love them both. Operations.

Comments

@krisnova
Copy link
Contributor

Upon merging a PR to main (or committing directly to the branch because I am a horrible person) a GitHub action is kicked off to update the static site using GitHub pages. Shortly after the event, the website aurae.io will return a 404.

Looking in the get GitHub pages settings for the repository the domain name value is unexpectedly missing.

image

Setting the value back to aurae.io fixes the 404 and the site is now updated with the most recent changes from the main branch.

@krisnova krisnova added the Good First Issue New to the project? Looking for something to get started with? label Oct 18, 2022
@krisnova
Copy link
Contributor Author

Confirmed. Any merge or push to the main branch will break the website and result in a 404

image

@tcbyrd
Copy link

tcbyrd commented Oct 19, 2022

👋 from the Pages team. I was checking out your project and noticed this, so thought I'd offer a suggestion. It's now possible to use Actions as the source, which allows you to have more control over the build. This option also removes the requirement for a CNAME file to exist, and you can deploy from any branch to Pages.

Happy to open a PR with an starter workflow to set this up if you like.

@krisnova
Copy link
Contributor Author

Hey @tcbyrd welcome to the Aurae project. Hope you love it here!

Feel free to start a pull request for us, we would love to use whatever best practices you suggest. I think in general myself and the others working on the project aren't the most experienced with Pages or Actions, so any clues and contributions would be amazing.

@krisnova krisnova added the Ops Pre or Post, we love them both. Operations. label Oct 24, 2022
@krisnova
Copy link
Contributor Author

Also relevant to note that changing the CNAME file location to the configured directory Pages was looking in seemed to address this issue. I plan on making some changes to the GitHub documentation to clarify this as well.

#56 👀

@krisnova krisnova reopened this Oct 24, 2022
@krisnova
Copy link
Contributor Author

Another related issue about helping myself and the maintainers keep an eye on things if the build breaks and the website goes down. #82

@krisnova
Copy link
Contributor Author

So the website has been down all morning. I checked the pages settings and it looks like the page settings had been reversed? All of our GitHub pages configuration was lost.

https://github.com/aurae-runtime/aurae/settings/pages

I had to to back to the settings and re-enable the pages integration, select a branch, and re-enter the custom domain name. Waiting to see if the website comes back online.

@krisnova
Copy link
Contributor Author

Small update. In order to bring the site back online in its "final form" we need to point github pages at the gh-pages branch. This is the working config. Its been one of those exciting days!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue New to the project? Looking for something to get started with? Ops Pre or Post, we love them both. Operations.
Projects
None yet
Development

No branches or pull requests

2 participants