Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md usage example problem ($profiler) #12

Closed
cxj opened this issue Apr 21, 2015 · 4 comments
Closed

README.md usage example problem ($profiler) #12

cxj opened this issue Apr 21, 2015 · 4 comments

Comments

@cxj
Copy link
Contributor

cxj commented Apr 21, 2015

I haven't figured out the correct usage yet myself, or I'd file a pull request. But at the moment, the example usage code fails with PHP error on undefined $profiler.
@harikt
Copy link
Member

harikt commented Apr 21, 2015

You can send a PR with the changes

use Aura\Sql\Profiler;

$profiler = new Profiler();
$connection_locator = new ConnectionLocator(function () use ($profiler) {

Thank you for reporting.

@cxj
Copy link
Contributor Author

cxj commented Apr 21, 2015

Will do. Thanks, Harikt!

@harikt
Copy link
Member

harikt commented Apr 21, 2015

You are welcome @cxj :) .

@harikt
Copy link
Member

harikt commented Apr 21, 2015

Closing in favor of #13

@harikt harikt closed this as completed Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harikt @cxj